Skip to content

PERF: Improve performance for astype is view #57478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 17, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This came up in asvs, it wasn't much but we can do better

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jorisvandenbossche
Copy link
Member

(there is a mypy error ...)

@jorisvandenbossche jorisvandenbossche added Performance Memory or execution speed performance Copy / view semantics labels Feb 19, 2024
@mroeschke mroeschke added this to the 3.0 milestone Mar 18, 2024
@mroeschke mroeschke merged commit 2b50039 into pandas-dev:main Mar 18, 2024
46 of 47 checks passed
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the perf_cow_astype branch March 18, 2024 20:56
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* PERF: Improve performance for astype is view

* Update

* Update

* Fixup

* Update astype.py

* Update astype.py

---------

Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy / view semantics Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants