Skip to content

PERF: DataFrame(ndarray) constructor ensure to copy to column-major layout #57459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2024
Merged

PERF: DataFrame(ndarray) constructor ensure to copy to column-major layout #57459

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acbdcff
PERF: DataFrame(ndarray) constructor ensure to copy to column-major l…
jorisvandenbossche Feb 16, 2024
bad7dd6
fixup
jorisvandenbossche Feb 19, 2024
a07a08e
Merge branch 'main' into cow-frame-constuctor-copy
mroeschke Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pandas/core/internals/construction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,12 @@ def ndarray_to_mgr(

elif isinstance(values, (np.ndarray, ExtensionArray)):
# drop subclass info
_copy = (
copy if (dtype is None or astype_is_view(values.dtype, dtype)) else False
)
values = np.array(values, copy=_copy)
if copy and (dtype is None or astype_is_view(values.dtype, dtype)):
# only force a copy now if copy=True was requested
# and a subsequent `astype` will not already result in a copy
values = np.array(values, copy=True, order="F")
else:
values = np.array(values, copy=False)
values = _ensure_2d(values)

else:
Expand Down