Skip to content

DOC: Set verbose parameter as deprecated in docstring #57450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

albertvillanova
Copy link
Contributor

@albertvillanova albertvillanova commented Feb 16, 2024

This PR follows:

TODO:

@albertvillanova albertvillanova changed the title Set verbose parameter as deprecated in docstring DOC: Set verbose parameter as deprecated in docstring Feb 16, 2024
@datapythonista datapythonista added Docs IO CSV read_csv, to_csv Deprecate Functionality to remove in pandas labels Feb 16, 2024
@datapythonista
Copy link
Member

/preview

1 similar comment
@datapythonista
Copy link
Member

/preview

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for taking care of this @albertvillanova

@phofl phofl removed the Deprecate Functionality to remove in pandas label Feb 16, 2024
@phofl phofl added this to the 2.2.1 milestone Feb 16, 2024
@phofl phofl merged commit 0da30dd into pandas-dev:main Feb 16, 2024
@phofl
Copy link
Member

phofl commented Feb 16, 2024

thx

@datapythonista
Copy link
Member

There was a problem with the previewer, seems like GitHub only returns the first 30 elements of a request by default, we've got more than 30 jobs, and the job we needed to download the artifact wasn't being returned. I increased the number of returned items to 100, the maximum, and seems like the preview is working again.

This is rendering as expected:

https://pandas.pydata.org/preview/pandas-dev/pandas/57450/docs/reference/api/pandas.read_csv.html

Thanks again @albertvillanova and sorry for the noise.

@albertvillanova albertvillanova deleted the set-verbose-deprecated-in-docstring branch February 16, 2024 14:45
mroeschke pushed a commit that referenced this pull request Feb 16, 2024
…recated in docstring) (#57455)

Backport PR #57450: DOC: Set verbose parameter as deprecated in docstring

Co-authored-by: Albert Villanova del Moral <[email protected]>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Set verbose parameter as deprecated in docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Parameter verbose does not appear as deprecated
3 participants