BUG: wrong future Warning on string assignment in certain condition #57402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 14, 2024
pandas/core/indexing.py
Outdated
| # Columns F and G will initially be set to np.void. | ||
| # Here, we replace those temporary `np.void` columns with | ||
| # columns of the appropriate dtype, based on `value`. | ||
| arr = sanitize_array(value, Index(range(1)), copy=False) |
There was a problem hiding this comment.
construct_1d_arraylike_from_scalar?
There was a problem hiding this comment.
Discussed during the dev meeting. If the idea is to fill with the appropriate missing value, I think you can use a combination of infer_fill_value with construct_1d_arraylike_from_scalar
There was a problem hiding this comment.
thanks! will update
There was a problem hiding this comment.
I think this would run into the same issues that #56321 addressed
I'd factored out the common logic, if there's a better way perhaps it can be addressed separately?
mroeschke
added
Warnings
phofl
reviewed
Feb 14, 2024
mroeschke
approved these changes
Feb 16, 2024
|
Thanks @MarcoGorelli |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 16, 2024
…ignment in certain condition
mroeschke
pushed a commit
that referenced
this pull request
Feb 16, 2024
…ng assignment in certain condition) (#57460) Backport PR #57402: BUG: wrong future Warning on string assignment in certain condition Co-authored-by: Marco Edward Gorelli <[email protected]>
3 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…andas-dev#57402) * whatsnew * factor out construct_1d_array_from_inferred_fill_value * 🏷️ typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.is this it? finally? 🤞