-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: Format rst code blocks with blacken-docs #57401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What's the plan with this @tqa236? Are the problems in the CI a blocker to move forward with this? |
hi @datapythonista, this problem is not related to the recent broken CI, although the broken CI indeed doesn't help testing or exploring. The exact issue that prevents us from having a green CI is just the number of new lines in some code blocks in the doc where The approach I'm exploring now is a way to disable this warning by passing I raised the issue here and here as well, but any quick change seems unlikely. If you can point me to where I can pass |
Thanks for the update @tqa236. I can't find the warnings in the doc build, are they still happening? Configuration changes should be placed in I don't fully understand why ipython/nbsphinx should complain about blank lines, they shouldn't validate the style or format that I know, just execute the code. I can have a look if you can point me to the warnings that are making the CI fail, I only see an error I think I saw in other PRs about the section underlines. CC @MarcoGorelli in case you have any opinion here. |
thanks for pointing me to the conf file, @datapythonista. I'm able to pass the IPython config to the sphinx build now. Unfortunately, my approach doesn't work yet, as a warning is still raised, and sphinx will fail the build because of that. I'll need to think of another solution. |
closed as I don't know how to proceed yet. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.