implemented description property #574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes this is correct git usage :) The problem with this is that as soon as you do anything with the DataFrame you've created the column metadata is going to be lost. Probably the right way to do it would be to store the information inside the column index itself. So it's a bit of an involved undertaking. I will take a closer look at your patch and think about how much work it would be to do |
|
That makes sense. Let me know! |
|
Hey sorry this PR has been open for so long. I'm going to close it until more work is put into a deeper solution for tracking metadata. It's a pretty big project I think |
dan-nadler
pushed a commit
to dan-nadler/pandas
that referenced
this pull request
Sep 23, 2019
add host to VersionedItem (adds feature pandas-dev#595)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a basic implementation of description and unit properties in DataFrame.
https://github.com/wesm/pandas/issues/39
I used dict to store both description and unit. I thought about using tuples but dict would be better if a user wants to modify individual descripition/unit.
One can directly access description/unit, and also DataFrame.info() will print out those if they exist.
I haven't touched at the storing part yet so it is very rudimentary now (no way to save the descriptions), but I wanted to know what you think. Please let me know.
And also, is this (topic branch) right way to submit a pull request? I'm still learning about git. :)
Happy new year!
-Joon