-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Ensure consistent kwarg only restriction on df.any and df.all #57396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These would need deprecating first cc @twoertwein
Oh, my bad, okay 👌 |
Luckily, it is quite simple:
These deprecations apply to both DataFrame and Series for at least the following methods: any, all, min, max, mean, median, sum, prod, std, var, sem, skew, kurt. I had similar changes in this PR but removed them from the PR to keep it easier to merge. Feel free to have a look at that PR to see how to adjust some of the tests (some of them will fail when you deprecate positional arguments). |
Thank you for explaining, this is super helpful! 👍 |
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
DataFrame.any()
inconsistent with other methods #57087doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.