TST: Fix test_str_encode on big endian machines #57394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
force-pushed
the
test-be-str_encode
branch
from
fc91a9c to
8bd8853
Compare
I couldn't find a way to specify the endianness when creating the `ArrowDtype`, so just pick the right result based on native byte order.
QuLogic
force-pushed
the
test-be-str_encode
branch
from
8bd8853 to
ee55db7
Compare
simonjayhawkins
added
Testing
WillAyd
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
We don't explicitly support BE machines nor do we have any in CI for the test suite. However, I am fine with this PR @mroeschke
mroeschke
approved these changes
Feb 13, 2024
|
Sure thanks @QuLogic |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
I couldn't find a way to specify the endianness when creating the `ArrowDtype`, so just pick the right result based on native byte order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find a way to specify the endianness when creating the
ArrowDtype, so just pick the right result based on native byte order.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.