-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REGR: merge with 3rd party EA's can sometimes raise ValueError #57333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -301,7 +301,7 @@ cdef class IndexEngine: | |||
values = self.values | |||
self.monotonic_inc, self.monotonic_dec, is_strict_monotonic = \ | |||
self._call_monotonic(values) | |||
except (TypeError, InvalidOperation): | |||
except (TypeError, InvalidOperation, ValueError): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we test this somehow? We have "test_downstream.py" for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you be ok with just testing against a pyarrow list type? e.g. this raises a ValueError
:
import pyarrow as pa
import pandas as pd
arr = pd.array([[1], [2, 3]], dtype=pd.ArrowDtype(pa.list_(pa.int64())))
pd.Index(arr).is_monotonic_increasing # ValueError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep that’s fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to avoid that someone removes the ValueError and the tests don’t fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, test added
Thx @lukemanley |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…etimes raise ValueError
doc/source/whatsnew/v2.2.1.rst
file if fixing a bug or adding a new feature.