REGR: Fix regression when grouping over a Series #57323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Regression
jorisvandenbossche
approved these changes
Feb 10, 2024
| ref = weakref.ref(self.blocks[blkno]) | ||
| return ref in mgr.blocks[blkno].refs.referenced_blocks | ||
| blk = self.blocks[blkno] | ||
| return any(blk is ref() for ref in mgr.blocks[blkno].refs.referenced_blocks) |
There was a problem hiding this comment.
At the point where df["col"].index is df.index is no longer true, we will have to update this, but I assume we can handle that at that point
There was a problem hiding this comment.
That should work anyway though, since df.col.index will also be in the references since it still shares values with df.index. All shallow copies of the original values should be in there, that’s the elegant think about the tracking mechanism
There was a problem hiding this comment.
Actually index checks will never get there since it's defined on the manager
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 10, 2024
phofl
added a commit
that referenced
this pull request
Feb 10, 2024
…g over a Series) (#57339) Backport PR #57323: REGR: Fix regression when grouping over a Series Co-authored-by: Patrick Hoefler <[email protected]>
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.