Skip to content

CLN: Remove literal string/bytes support in IO readers #57307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 10, 2024

Conversation

mroeschke
Copy link
Member

xref #53767

@mroeschke mroeschke added IO Data IO issues that don't fit into a more specific label Clean labels Feb 8, 2024
@mroeschke mroeschke requested a review from rhshadrach as a code owner February 8, 2024 22:11
df = pd.DataFrame({"a": range(3), "b": list("abc")})
print(df)
html = df.to_html()
alist = pd.read_html(html, index_col=0)
alist = pd.read_html(io.StringIO(html), index_col=0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as this is such an old whatsnew is is possible to not change this (other than making this not run the code?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the :okwarning: was supressing the deprecation warning, so the only other way would be to change to a code-block

@mroeschke mroeschke added this to the 3.0 milestone Feb 9, 2024
@phofl phofl merged commit 862d431 into pandas-dev:main Feb 10, 2024
@phofl
Copy link
Member

phofl commented Feb 10, 2024

thx @mroeschke

@mroeschke mroeschke deleted the rm/literal_io branch February 12, 2024 17:02
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean IO Data IO issues that don't fit into a more specific label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants