Skip to content

REGR/DOC: pd.concat should special case DatetimeIndex to sort even when sort=False #57250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

lukemanley
Copy link
Member

Reverts the changes from #54769 due to long-standing behavior and documents the behavior instead.

See discussion regarding the inconsistency of the long-standing behavior here: #57006 (comment)

@lukemanley lukemanley added Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode Regression Functionality that used to work in a prior pandas version labels Feb 4, 2024
@lukemanley lukemanley added this to the 2.2.1 milestone Feb 4, 2024
@phofl phofl merged commit a90c6f8 into pandas-dev:main Feb 9, 2024
@phofl
Copy link
Member

phofl commented Feb 9, 2024

thx @lukemanley

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 9, 2024
mroeschke pushed a commit that referenced this pull request Feb 9, 2024
…l case DatetimeIndex to sort even when sort=False) (#57326)

Backport PR #57250: REGR/DOC: pd.concat should special case DatetimeIndex to sort even when sort=False

Co-authored-by: Luke Manley <[email protected]>
@mroeschke
Copy link
Member

IMO I think this case should still be deprecated. Carve-outs like this ultimately lead to confusion

@lukemanley
Copy link
Member Author

IMO I think this case should still be deprecated. Carve-outs like this ultimately lead to confusion

I opened #57335 for discussion.

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Regression Functionality that used to work in a prior pandas version Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REGR/DOC: pd.concat(axis=1) should special case DatetimeIndex to sort even when sort=False
3 participants