Update type hint in io/formats/format.py #57249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The brackets around the type hint broke the libcst parser. Since the brackets are not necessary for the type hint, they have been removed
twoertwein
reviewed
Feb 4, 2024
Type annotation changes are not added to change log
twoertwein
approved these changes
Feb 4, 2024
|
@twoertwein i've milestoned 3.0 since we normally don't backport typing changes and the problem code has not been modified recently but if the superfluous parenthesis breaks things feel feel to change to 2.2.1 as it would probably do no harm. |
|
Thank you @FrostMegaByte! I'm with you, @simonjayhawkins, on not backporting (it doesn't impact major typecheckers and seems more like a libcst issue), but I have no strong opinion. |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Update type hint in format.py The brackets around the type hint broke the libcst parser. Since the brackets are not necessary for the type hint, they have been removed * Update v2.2.1.rst * Undo update to v2.2.1.rst Type annotation changes are not added to change log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The brackets around the type hint broke the libcst parser. Since the brackets are not necessary for the type hint, they have been removed
format_percentilesfunction inio/formats/format.py#57248doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.