Skip to content

BUG: ensure_string_array might modify read-only array inplace #57212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2024

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 2, 2024

We ran into this in Dask, it's quite the edge case...

@phofl phofl requested a review from WillAyd as a code owner February 2, 2024 13:51
@phofl phofl closed this Feb 3, 2024
@phofl phofl reopened this Feb 3, 2024
@rhshadrach rhshadrach added Strings String extension data type and string data Bug labels Feb 4, 2024
@mroeschke mroeschke added this to the 3.0 milestone Feb 4, 2024
@mroeschke mroeschke merged commit ba76f73 into pandas-dev:main Feb 4, 2024
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the read_only_array_string_cast branch February 4, 2024 18:16
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…-dev#57212)

* BUG: ensure_string_array might modify read-only array inplace

* BUG: ensure_string_array might modify read-only array inplace

* Fix pyarrow installed error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants