DOC: trim CONTRIBUTING.MD #5721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
merged commit 
| Even regular contributors who test religiously on their local box (using tox | ||
| for example) often rely on a PR+travis=green to make double sure everything | ||
| works ok on another system, as occasionally, it doesn't. | ||
| It's important to get travis working as PRs won't generally get merged until travis is green. |
There was a problem hiding this comment.
we don't (necessarily) need this anymore, every PR to pydata/pandas should cause Travis to build automatically.
There was a problem hiding this comment.
I seem to recall at least one PR submitted after that change which didn't have
a travis build attached to it. Have you explicitly tested that it works? if yes, let's drop the
travis hand-holding sections altogether.
There was a problem hiding this comment.
I'm convinced, I pushed another commit to remove it all.
4 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working on the 140 char version. maybe we should just use the sha1 instead. hmm.