STY: Enable some passing rules #57200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
reviewed
Feb 2, 2024
| @@ -55,15 +55,15 @@ def test_array_scalar_like_equivalence(data, all_arithmetic_operators): | |||
| scalar_array = pd.array([scalar] * len(data), dtype=data.dtype) | |||
|
|
|||
| # TODO also add len-1 array (np.array([scalar], dtype=data.dtype.numpy_dtype)) | |||
| for scalar in [scalar, data.dtype.type(scalar)]: | |||
| for val in [scalar, data.dtype.type(scalar)]: | |||
There was a problem hiding this comment.
What rule is this?
Not sure I like this change (or if its worth the churn).
There was a problem hiding this comment.
https://docs.astral.sh/ruff/rules/loop-variable-overrides-iterator/
I think this could be useful generally. In the file above (pandas/io/json/_normalize.py), if v needed to be used after looping it would no longer be the original object it would be an object element
There was a problem hiding this comment.
My bad, wasn't paying too close attention.
I guess a more descriptive name would be nicer, but I'm fine with it as it is.
datapythonista
approved these changes
Feb 2, 2024
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Enable B006 * Enable B011 * Enable B019 * Enable B020 * Enable B020 * Enable PYI and othe rule * Enable PLC1901 * Use values instead of items * Use union * Ignore one case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.