DEPR: Enforce deprecation of groupby(..., axis=1) #57186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 1, 2024
doc/source/whatsnew/v3.0.0.rst
Outdated
| @@ -102,8 +102,10 @@ Deprecations | |||
| Removal of prior version deprecations/changes | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| - Removed :meth:`DataFrameGroupby.fillna` and :meth:`SeriesGroupBy.fillna` (:issue:`55719`) | |||
| - Removed ``axis`` argument from :meth:`DataFrame.groupby` and :meth:`Series.groupby` (:issue:`51203`) | |||
There was a problem hiding this comment.
Could you mention rolling and resample too?
rhshadrach
commented
Feb 1, 2024
Comment on lines
+1524
to
1526
| # We have multi-block tests | ||
| # e.g. test_rank_min_int, test_cython_transform_frame | ||
| # test_transform_numeric_ret |
There was a problem hiding this comment.
I think this comment can be fully removed now, but wanted to make sure.
There was a problem hiding this comment.
I think so too. Can be done in a follow up
# Conflicts: # doc/source/whatsnew/v3.0.0.rst # pandas/core/groupby/generic.py
mroeschke
approved these changes
Feb 1, 2024
|
Thanks @rhshadrach |
23 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* DEPR: Enforce deprecation of groupby(..., axis=1) * More removals and cleanups * whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Enforcing #51203