Skip to content

BUG: pandas int extension dtypes has no attribute byteorder #57173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 1, 2024
Merged

BUG: pandas int extension dtypes has no attribute byteorder #57173

merged 5 commits into from
Feb 1, 2024

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli marked this pull request as ready for review January 31, 2024 15:34
mroeschke
mroeschke reviewed Jan 31, 2024
View reviewed changes
pandas/core/interchange/column.py Outdated
@@ -143,6 +146,8 @@ def _dtype_from_pandasdtype(self, dtype) -> tuple[DtypeKind, int, str, str]:
byteorder = dtype.numpy_dtype.byteorder
elif isinstance(dtype, DatetimeTZDtype):
byteorder = dtype.base.byteorder # type: ignore[union-attr]
elif is_extension_array_dtype(dtype):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check BaseMaskedDtype instead?

@mroeschke mroeschke added NA - MaskedArrays Related to pd.NA and nullable extension arrays Interchange Dataframe Interchange Protocol labels Jan 31, 2024
WillAyd
WillAyd reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

pandas/tests/interchange/test_impl.py Outdated
@pytest.mark.parametrize("dtype", ["Int8", "Int8[pyarrow]"])
def test_nullable_integers(dtype: str) -> None:
# https://github.com/pandas-dev/pandas/issues/55069
pytest.importorskip("pyarrow")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to skip for the second case no? Any reason we don't just use pytest.param("Int8[pyarrow], marks=td.skip_if_no("pyarrow"))?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I didn't know you could do that 🙈

@lesteve lesteve mentioned this pull request Feb 1, 2024
Closed
@mroeschke mroeschke added this to the 2.2.1 milestone Feb 1, 2024
@mroeschke mroeschke merged commit 0fd7176 into pandas-dev:main Feb 1, 2024
@mroeschke
Copy link
Member

Thanks @MarcoGorelli

@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Feb 1, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 0fd71768147d6cace22f99c6fca7dc19679337ff
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #57173: BUG: pandas int extension dtypes has no attribute byteorder'
  1. Push to a named branch:
git push YOURFORK 2.2.x:auto-backport-of-pr-57173-on-2.2.x
  1. Create a PR against branch 2.2.x, I would have named this PR:

"Backport PR #57173 on branch 2.2.x (BUG: pandas int extension dtypes has no attribute byteorder)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

MarcoGorelli added a commit to MarcoGorelli/pandas that referenced this pull request Feb 1, 2024
@MarcoGorelli
Backport PR pandas-dev#57173: BUG: pandas int extension dtypes has no…
6efa60d 
… attribute byteorder
mroeschke pushed a commit that referenced this pull request Feb 1, 2024
@MarcoGorelli
Backport PR #57173: BUG: pandas int extension dtypes has no attribute… (
62aea0f 
#57198)

Backport PR #57173: BUG: pandas int extension dtypes has no attribute byteorder
MarcoGorelli added a commit to MarcoGorelli/pandas that referenced this pull request Mar 1, 2024
@MarcoGorelli
BUG: pandas int extension dtypes has no attribute byteorder (pandas-d…
ea3eccd 
…ev#57173)

* support nullable integers in from_dataframe

* gh issue number

* use BaseMaskedDtype

* only skip if int8[pyarrow]

(cherry picked from commit 0fd7176)
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@MarcoGorelli @pmhatre1
BUG: pandas int extension dtypes has no attribute byteorder (pandas-d…
4c9a457 
…ev#57173)

* support nullable integers in from_dataframe

* gh issue number

* use BaseMaskedDtype

* only skip if int8[pyarrow]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd left review comments

@mroeschke mroeschke mroeschke approved these changes

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche

Assignees
No one assigned
Labels
Interchange Dataframe Interchange Protocol NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

BUG: pandas int extension dtypes has no attribute byteorder
3 participants
@MarcoGorelli @mroeschke @WillAyd