Skip to content

CI: avoid DeprecationWarning in validate_min_versions_in_sync script #57127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2024
Merged

CI: avoid DeprecationWarning in validate_min_versions_in_sync script #57127

merged 2 commits into from
Jan 31, 2024

Conversation

MarcoGorelli
Copy link
Member

this warning is showing up in CI because of the extra whitespace here

pandas/scripts/tests/data/deps_expected_random.yaml

Line 41 in 09cb367

- pyarrow<11, >=7.0.0

which then goes to the except arm in

pandas/pandas/util/version/__init__.py

Lines 122 to 125 in ffc5839

try:
return Version(version)
except InvalidVersion:
return LegacyVersion(version)

which throws the warning

@MarcoGorelli MarcoGorelli marked this pull request as ready for review January 31, 2024 15:21
@MarcoGorelli MarcoGorelli added the CI Continuous Integration label Jan 31, 2024
@mroeschke mroeschke added this to the 3.0 milestone Jan 31, 2024
@mroeschke mroeschke merged commit 0ec21fa into pandas-dev:main Jan 31, 2024
@mroeschke
Copy link
Member

Thanks @MarcoGorelli

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@MarcoGorelli @pmhatre1
CI: avoid DeprecationWarning in validate_min_versions_in_sync script (p…
f66669f 
…andas-dev#57127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGorelli @mroeschke