-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPR: Enforce deprecation of ArrayManager #57118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
cfe6cb2
1e821bd
93f86f5
b4013c4
8917cfa
71e66e3
0b68325
faa58de
4a1f92c
04bba91
e347105
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ | |
Optional, | ||
Protocol, | ||
Type as type_t, | ||
TypeAlias, | ||
TypeVar, | ||
Union, | ||
overload, | ||
|
@@ -61,9 +62,7 @@ | |
) | ||
from pandas.core.indexes.base import Index | ||
from pandas.core.internals import ( | ||
ArrayManager, | ||
BlockManager, | ||
SingleArrayManager, | ||
SingleBlockManager, | ||
) | ||
from pandas.core.resample import Resampler | ||
|
@@ -382,11 +381,9 @@ def closed(self) -> bool: | |
] | ||
|
||
# internals | ||
Manager = Union[ | ||
"ArrayManager", "SingleArrayManager", "BlockManager", "SingleBlockManager" | ||
] | ||
SingleManager = Union["SingleArrayManager", "SingleBlockManager"] | ||
Manager2D = Union["ArrayManager", "BlockManager"] | ||
Manager = Union["BlockManager", "SingleBlockManager"] | ||
SingleManager: TypeAlias = "SingleBlockManager" | ||
Manager2D: TypeAlias = "BlockManager" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if these are still useful - can remove There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only useful if they are used elsewhere in the code There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They are used - but I'm not sure that makes them useful. We can replace any current usage of SingleManager with SingleBlockManager. I tracked it down, this was added in #40152, so I think it makes sense to remove. |
||
|
||
# indexing | ||
# PositionalIndexer -> valid 1D positional indexer, e.g. can pass | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not supported in python 3.9, so you should import it from
typing_extensions