TYP: misc return values #57108
Merged
TYP: misc return values #57108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Jan 27, 2024
| @@ -1818,10 +1821,14 @@ def value_counts(self, dropna: bool = True) -> Series: | |||
| ix = np.append(ix, -1) | |||
|
|
|||
| ix = coerce_indexer_dtype(ix, self.dtype.categories) | |||
| ix = self._from_backing_data(ix) | |||
| ix_categorical = self._from_backing_data(ix) | |||
There was a problem hiding this comment.
I would prefer to set mypy's allow_redefinition to true to avoid having to change the runtime behavior slightly (ix isn't freed immediately). Pyright allows redefinitions.
mroeschke
approved these changes
Jan 29, 2024
|
Thanks @twoertwein |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.