Skip to content

Update install.rst to match the newest code #57081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 26, 2024

Conversation

NewUserHa
Copy link
Contributor

@NewUserHa NewUserHa commented Jan 26, 2024

enhancing the Excel files related documents of pandas

@mroeschke
Copy link
Member

Thanks for the PR but I think the order of these dependencies is fine as is so closing

@mroeschke mroeschke closed this Jan 26, 2024
@NewUserHa
Copy link
Contributor Author

NewUserHa commented Jan 26, 2024

the important changes are completed the usage of notes for each depencies for excel, and added the missing 'odfpy' which exists in pyproject.toml but not in documents.

the order of these dependencies is not important

@mroeschke
Copy link
Member

OK sorry the diff did not make that obvious. Could you remove the re-ordering so the diff is clearer?

@mroeschke mroeschke reopened this Jan 26, 2024
@mroeschke mroeschke added the IO Excel read_excel, to_excel label Jan 26, 2024
@NewUserHa
Copy link
Contributor Author

ok, should keep the order of dependencies in both the documents and pyproject.toml be consistently the same? or also doesn't matter?

@mroeschke
Copy link
Member

The ordering in either is not important so I would keep the existing ordering for clarity

@NewUserHa
Copy link
Contributor Author

ok the re-ordering is removed

@mroeschke mroeschke added this to the 3.0 milestone Jan 26, 2024
@mroeschke mroeschke merged commit 1fee25c into pandas-dev:main Jan 26, 2024
@mroeschke
Copy link
Member

Thanks @NewUserHa

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* Update install.rst to match the newest code

* Update pyproject.toml

* Update install.rst

* Update pyproject.toml

* Update install.rst

* Update install.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants