-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
API: MultiIndex.names|codes|levels returns tuples #57042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5b791e1
MultiIndex.names|codes|levels returns tuples
mroeschke 5f87ec6
Fix typing
mroeschke 85ca838
Add whatsnew note
mroeschke 0dab99a
Merge remote-tracking branch 'upstream/main' into ref/mi/tuples
mroeschke d73ded2
Fix stacking
mroeschke 31e0153
Merge remote-tracking branch 'upstream/main' into ref/mi/tuples
mroeschke 8a36d34
Fix doctest, test
mroeschke 7c511ce
Fix other test
mroeschke 87e173c
Merge remote-tracking branch 'upstream/main' into ref/mi/tuples
mroeschke e1c3668
Merge remote-tracking branch 'upstream/main' into ref/mi/tuples
mroeschke 594a7a3
Merge remote-tracking branch 'upstream/main' into ref/mi/tuples
mroeschke a4df4c5
Merge remote-tracking branch 'upstream/main' into ref/mi/tuples
mroeschke c996730
Remove example
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line leading into this is:
If we want to preserve this, one can do
[e for e in df2.index.names if e not in {"A"}]
. But I'd also be okay to remove the entire example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried taking union and difference here might be a common use case that we're breaking. I'm okay with removing the feature, but we could deprecate uses of these methods to make the breaking change a bit more soft. Of course, with our deprecation policy that would mean punting this off for some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. If you feel strongly about it we can go through a deprecation, but the fact that FrozenList was never really publically documented (except indirectly here with this example) makes me OK with breaking this use case.
As a data point, in cudf uses
FrozenList
incudf.MultiIndex
to match return types but has no usage ofFrozenList.union/difference
xref #44823
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not feel strongly here. Okay to go forward in my opinion.