-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REGR: perf regression in Series.combine_first #57034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -87,6 +87,7 @@ | |||
from pandas.core.dtypes.dtypes import ( | |||
CategoricalDtype, | |||
ExtensionDtype, | |||
SparseDtype, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprising to see this here. Maybe more motivation for #56518
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, a bit unfortunate. Alternatively, the sparse issue was previously xfailed and could be xfailed again in order to avoid this:
Thanks @lukemanley |
…ombine_first) (#57072) Backport PR #57034: REGR: perf regression in Series.combine_first Co-authored-by: Luke Manley <[email protected]>
* fix perf regression in Series.combine_first * fix
doc/source/whatsnew/v2.2.1.rst
file if fixing a bug or adding a new feature.