DEP: Loosely pin Cython to 3.0 #56993
Conversation
| @@ -8,7 +8,7 @@ dependencies: | |||
|
|
|||
| # build dependencies | |||
| - versioneer[toml] | |||
| - cython=3.0.5 | |||
| - cython~=3.0.5 | |||
There was a problem hiding this comment.
Any reason for pinning to 3.0 instead of a more general >= 3.0 range?
There was a problem hiding this comment.
I meant to put this in the OP but forgot: I brought this up at the dev meeting in December. I am wondering if minor releases should be benchmarked first before we upgrade. The general consensus was that patch versions are fine to automatically take, but there was uncertainty around minor versions.
No opposition to >= if people are comfortable with that.
There was a problem hiding this comment.
There was a problem hiding this comment.
This means any 3.0.x? Neat.
There was a problem hiding this comment.
OK cool. I have no objection to this, as long as someone takes the time to do it (your benchmarks were very helpful with the 3.x upgrade)
|
Thanks @rhshadrach |
|
Ah sorry should have looked at the failing check more closely, could you fix the pinning in the |
|
Yea - just noticed it. On it. |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.