TST: test for warnings using pytest.warns() #56974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 23, 2024
| @@ -194,7 +194,7 @@ def test_to_offset_lowercase_frequency_deprecated(freq_depr): | |||
| depr_msg = f"'{freq_depr[1:]}' is deprecated and will be removed in a " | |||
| f"future version, please use '{freq_depr.upper()[1:]}' instead." | |||
|
|
|||
| with pytest.raises(FutureWarning, match=depr_msg): | |||
| with pytest.warns(FutureWarning, match=depr_msg): | |||
There was a problem hiding this comment.
Please use tm.assert_produces_warning (and below)
mroeschke
added
the
Testing
Fix tests that used `pytest.raises()` to check for warnings, to use `tm.assert_produces_warning()` instead. This is more correct, and it fixes running the test suite without `-Werror`. This is how Gentoo runs it, to avoid sudden test failures due to new deprecation warnings from upgraded dependencies.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mroeschke
approved these changes
Jan 23, 2024
|
Thanks @mgorny |
|
Thanks! And sorry for not running pre-commit in the morning, as I've updated the PR just before going out. |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* TST: test for warnings using tm.assert_produces_warning() Fix tests that used `pytest.raises()` to check for warnings, to use `tm.assert_produces_warning()` instead. This is more correct, and it fixes running the test suite without `-Werror`. This is how Gentoo runs it, to avoid sudden test failures due to new deprecation warnings from upgraded dependencies. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests that used
pytest.raises()to check for warnings, to usepytest.warns()instead. This is more correct, and it fixes running the test suite without-Werror. This is how Gentoo runs it, to avoid sudden test failures due to new deprecation warnings from upgraded dependencies.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.