Autofix ruf010 #56914
Merged
Autofix ruf010 #56914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this rule conflicted with |
|
I would be okay enabling |
|
@mroeschke Thanks, I removed the old rule in the last commit. |
mroeschke
approved these changes
Jan 16, 2024
|
Thanks @tqa236 |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* STY: Autofix RUF010 * STY: Apply ruff format after autofix * STY: Final manual fix * STY: Remove old repl rule in pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As now
ruffhas an autofix forRUF010, I enable the rule.I separate the PR into 4 commits with the 4 actions I performed, you can review them one by one for a better diff.
Autofix
RUF010ruff formatFinal manual format
Remove old "unwanted pattern" rule in
pre-commitcloses #xxxx (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.