DEPR: freq ''2BQ-SEP" for to_period should raise an error #56906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoGorelli, could you please take a look at this PR? |
MarcoGorelli
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Awesome, well done spotting and fixing!
Doesn't need a whatsnew note as this hasn't hit users yet
I think the test location was good to begin with (test_to_period) as you're testing the to_period function here, not the Period constructor
but ok for a follow-up, good to get this in for 2.2!
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 16, 2024
…uld raise an error
mroeschke
pushed a commit
that referenced
this pull request
Jan 16, 2024
…od should raise an error) (#56916) Backport PR #56906: DEPR: freq ''2BQ-SEP" for to_period should raise an error Co-authored-by: Natalia Mokeeva <[email protected]>
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…#56906) correct def to_period, add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrected the definition to_period to raise an errror for
freq = '2BQ-SEP'and add testsNo whatsnew note as this is only on main yet.