Skip to content

DOC: EX03 fixes on dataframe.plot methods: hexbin, line #56900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

alpakpinar
Copy link
Contributor

@alpakpinar alpakpinar commented Jan 16, 2024

@alpakpinar alpakpinar requested a review from mroeschke as a code owner January 16, 2024 00:59
@jordan-d-murphy
Copy link
Contributor

@alpakpinar I don't think this should be marked to close #56804 yet,
There are still a few methods remaining to be fixed. Would you consider updating it to xref format?

I've been using this for my PRs:

@alpakpinar alpakpinar changed the title DOC: EX03 fixes on dataframe.plot methods DOC: EX03 fixes on dataframe.plot methods: hexbin, line Jan 16, 2024
@alpakpinar
Copy link
Contributor Author

@jordan-d-murphy thanks! I updated the description of this pull request and also #56898

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will wait until the CI finishes as I need to resolve a conflict, but this should be ready

@mroeschke mroeschke added this to the 3.0 milestone Jan 16, 2024
@mroeschke mroeschke merged commit 4ab95ad into pandas-dev:main Jan 16, 2024
@mroeschke
Copy link
Member

Thanks @alpakpinar

@alpakpinar alpakpinar deleted the dataframe-plot-ex3-fixes branch January 16, 2024 17:27
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…6900)

EX03 fixes on dataframe.plot methods

Co-authored-by: Marc Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants