Skip to content

STY: enable PLR5501 #56895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2024
Merged

STY: enable PLR5501 #56895

merged 1 commit into from
Jan 16, 2024

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Jan 15, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

datapythonista
datapythonista approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice clean up.

I'll let others review, in case there are different opinions.

@datapythonista datapythonista added Code Style Code style, linting, code_checks Clean labels Jan 16, 2024
@mroeschke mroeschke added this to the 3.0 milestone Jan 16, 2024
@mroeschke mroeschke merged commit ca70744 into pandas-dev:main Jan 16, 2024
@mroeschke
Copy link
Member

Thanks @tqa236

@tqa236 tqa236 deleted the enable-PLR5501 branch January 16, 2024 16:18
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@tqa236 @pmhatre1
STY: enable PLR5501 (pandas-dev#56895)
53908fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tqa236 @mroeschke @datapythonista