-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Fix setitem parametrizations #56890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -2051,6 +2054,8 @@ def setitem(self, indexer, value, using_cow: bool = False): | |||
# TODO(GH#45419): string[pyarrow] tests break if we transpose | |||
# unconditionally | |||
values = values.T | |||
|
|||
check_array_indexer(values, indexer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to understand how this relates to #31948 (for which the behavior seems to have changed since it was opened). Ideally we'd do checks on the indexer once at the DataFrame/Series level instead of at the block level which can end up doing them repeatedly. |
@jbrockmendel i updated #31948 with the current behavior. What would be the desired behavior? Maybe the test has wrong expectations... |
With
the main reason the test are failing is |
i opened a new PR, that only changes the |
@jbrockmendel @mroeschke maybe you can have a look at #57629 |
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
I'm not sure if i am on the right track with this PR but it's a try. If not i will close it and probably someone more into the code has to dig into that issue.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.