-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: fix EX03 errors in docstrings - pandas.Series.to_latex, pandas.read_pickle, pandas.DataFrame.to_latex, pandas.core.resample.Resampler.pipe #56843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: fix EX03 errors in docstrings - pandas.Series.to_latex, pandas.read_pickle, pandas.DataFrame.to_latex, pandas.core.resample.Resampler.pipe #56843
Conversation
….core.resample.Resampler.pipe
Looks like the check for macos-latest actions-312.yaml is failing, I cannot seem to find a way to re run the check. Any guidance would be appreciated. EDIT: FINAL EDIT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jordan-d-murphy, very nice. I added couple of comments that I think will make the documentation clearer for users, but great changes, thanks for fixing this.
@datapythonista I've responded to your comments and updated my code. Can you please review again when you have a moment? Thanks for all the detailed feedback. If any improvements are still needed I'm happy to revisit any issues that you find. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, maybe you want to incorporate the suggestion in my last comment, but looks good regardless. Thanks for the work on this, looks great.
Thanks @jordan-d-murphy, great work |
Checked if validation docstrings passes for :
OUTPUT:
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.