Fix integral truediv and floordiv for pyarrow types with large divisors #56707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanjain101
commented
Jan 3, 2024
|
|
||
| def floordiv_compat( | ||
| left: pa.ChunkedArray | pa.Array | pa.Scalar, | ||
| right: pa.ChunkedArray | pa.Array | pa.Scalar, | ||
| ) -> pa.ChunkedArray: | ||
| # Ensure int // int -> int mirroring Python/Numpy behavior | ||
| # as pc.floor(pc.divide_checked(int, int)) -> float | ||
| converted_left = cast_for_truediv(left, right) | ||
| result = pc.floor(pc.divide(converted_left, right)) | ||
| converted_left, converted_right = cast_for_truediv(left, right) |
There was a problem hiding this comment.
#56677 also fixes this for floordiv, IMO that is a more suitable fix for floordiv, since cpython and numpy implement floordiv without going through a double, but this fix is similar to #56647, I changed it for floordiv in this PR, only because the current floordiv implementation for integral types goes through truediv.
This fix should still apply to truediv, since both numpy and python truediv does an unsafe cast to a double:
>>> a = pd.Series([18014398509481983], dtype="int64")
>>> b = pd.Series([18014398509481984], dtype="int64")
>>> a / b
0 1.0
dtype: float64
>>>
added 2 commits
January 2, 2024 19:58
|
Combined fix into #56677 to reduce confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.