-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Added validation check for integer value for series.df #56688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you add a test case and a whatsnew comment like I mentioned in my original comment here? This is on the right track, though. |
@lithomas, I also found that algorithms.py should also need the check for the diff method. Do we have to open a new issue or shall I update both series.py and algorithms.py with the checks.My PR is updating the algorithms.py file but I can commit again with a series.py changes. |
I have added the mentioned testcase and whatsnew update @lithomas1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One minor comment in the wording.
Co-authored-by: Thomas Li <[email protected]>
Hi @lithomas1, I have completed all the checks.Can you let me know the next steps to close the PR? Also, thank you for all your help in setting up the environment. Looking forward to become active contributor to pandas hereon. |
Co-authored-by: Thomas Li <[email protected]>
thanks @pmhatre1 |
periods
#56607