Skip to content

Added validation check for integer value for series.df #56688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 7, 2024

Conversation

pmhatre1
Copy link
Contributor

@lithomas1
Copy link
Member

Can you add a test case and a whatsnew comment like I mentioned in my original comment here?

This is on the right track, though.

@lithomas1 lithomas1 added Error Reporting Incorrect or improved errors from pandas Series Series data structure Transformations e.g. cumsum, diff, rank labels Jan 1, 2024
@pmhatre1
Copy link
Contributor Author

pmhatre1 commented Jan 1, 2024

@lithomas, I also found that algorithms.py should also need the check for the diff method. Do we have to open a new issue or shall I update both series.py and algorithms.py with the checks.My PR is updating the algorithms.py file but I can commit again with a series.py changes.

@pmhatre1
Copy link
Contributor Author

pmhatre1 commented Jan 1, 2024

I have added the mentioned testcase and whatsnew update @lithomas1.

Copy link
Member

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment in the wording.

@pmhatre1
Copy link
Contributor Author

pmhatre1 commented Jan 6, 2024

Hi @lithomas1, I have completed all the checks.Can you let me know the next steps to close the PR? Also, thank you for all your help in setting up the environment. Looking forward to become active contributor to pandas hereon.

@pmhatre1 pmhatre1 closed this Jan 6, 2024
@pmhatre1 pmhatre1 reopened this Jan 6, 2024
@lithomas1
Copy link
Member

thanks @pmhatre1

@lithomas1 lithomas1 merged commit 7d61e32 into pandas-dev:main Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas Series Series data structure Transformations e.g. cumsum, diff, rank
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Series.diff does no arg validation unlike df.diff for periods
2 participants