add test for concating tzaware series with empty series. Issue: #34174 #56685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaohuanlin
changed the title
xiaohuanlin
force-pushed
the
add_test_for_concating_tz_aware_series
branch
from
128c31e to
57348c3
Compare
mroeschke
reviewed
Jan 2, 2024
pandas/tests/dtypes/test_concat.py
Outdated
Comment on lines
60
to
61
| tm.assert_index_equal(pd.Index([tzaware_time], dtype="object"), result.index) | ||
| tm.assert_series_equal(Series([0.0, None], name=tzaware_time), result.iloc[0]) |
There was a problem hiding this comment.
Could you construct an expected = pd.DataFrame(...) and use tm.assert_frame_equal(result, expected)?
There was a problem hiding this comment.
Sure. Just changed the format
xiaohuanlin
force-pushed
the
add_test_for_concating_tz_aware_series
branch
from
57348c3 to
d51a161
Compare
mroeschke
approved these changes
Jan 3, 2024
|
Thanks @xiaohuanlin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.