TYP: misc annotations #56667
Merged
TYP: misc annotations #56667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Dec 28, 2023
| @@ -36,7 +36,7 @@ | |||
| is_iterator = lib.is_iterator | |||
|
|
|||
|
|
|||
| def is_number(obj) -> TypeGuard[Number | np.number]: | |||
| def is_number(obj: object) -> TypeGuard[Number | np.number]: | |||
There was a problem hiding this comment.
Curious, is there any difference between object and Any?
There was a problem hiding this comment.
I think typeshed recommends to use object, when literally any object is accepted (typically for __eq__ and similar methods) and to use Any when it is too difficult to write a type annotation/when the code is too dynamic.
mroeschke
approved these changes
Dec 29, 2023
|
Thanks @twoertwein |
cbpygit
pushed a commit
to cbpygit/pandas
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.