Skip to content

Adjust crosstab tests for new string option #56526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2023
Merged

Adjust crosstab tests for new string option #56526

merged 1 commit into from
Dec 18, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 16, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added the Strings String extension data type and string data label Dec 16, 2023
@mroeschke mroeschke added this to the 2.2 milestone Dec 18, 2023
@mroeschke mroeschke merged commit 3b59484 into pandas-dev:main Dec 18, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the strings_corsstab branch December 18, 2023 19:23
cbpygit pushed a commit to cbpygit/pandas that referenced this pull request Jan 2, 2024
@phofl @cbpygit
Adjust crosstab tests for new string option (pandas-dev#56526)
e723d0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Strings String extension data type and string data
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke