-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Adjust merge tests for new string option #56445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # doc/source/whatsnew/v2.2.0.rst
Could you merge in main here once more? I think the precursor PR was merged already |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Thanks @phofl |
Co-authored-by: Patrick Hoefler <[email protected]>
* BUG: merge not raising for String and numeric merges * BUG: merge not sorting for new string dtype * Add coverage * Fixup tests * Update --------- Co-authored-by: Thomas Li <[email protected]>
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.