Skip to content

Adjust merge tests for new string option #56445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 11, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added this to the 2.2 milestone Dec 11, 2023
@phofl phofl added the Strings String extension data type and string data label Dec 11, 2023
@mroeschke
Copy link
Member

Could you merge in main here once more? I think the precursor PR was merged already

@mroeschke mroeschke merged commit 9e0b655 into pandas-dev:main Jan 17, 2024
Copy link

lumberbot-app bot commented Jan 17, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 9e0b6556b77b554f43067d06057dd05c6e8b8dc4
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #56445: Adjust merge tests for new string option'
  1. Push to a named branch:
git push YOURFORK 2.2.x:auto-backport-of-pr-56445-on-2.2.x
  1. Create a PR against branch 2.2.x, I would have named this PR:

"Backport PR #56445 on branch 2.2.x (Adjust merge tests for new string option)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@mroeschke
Copy link
Member

Thanks @phofl

lithomas1 pushed a commit to lithomas1/pandas that referenced this pull request Jan 18, 2024
lithomas1 added a commit that referenced this pull request Jan 18, 2024
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* BUG: merge not raising for String and numeric merges

* BUG: merge not sorting for new string dtype

* Add coverage

* Fixup tests

* Update

---------

Co-authored-by: Thomas Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants