Skip to content

ENH: unify warning message in to_offset() #56417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2023
Merged

ENH: unify warning message in to_offset() #56417

merged 2 commits into from
Dec 12, 2023

Conversation

natmokval
Copy link
Contributor

xref #56346

unified warning message for deprecated frequencies in to_offset in order to make test parametrization more clear

@natmokval natmokval added the Frequency DateOffsets label Dec 8, 2023
@natmokval natmokval marked this pull request as ready for review December 9, 2023 00:35
@natmokval
Copy link
Contributor Author

@MarcoGorelli, could you please take a look at this PR?
We have two slightly different warnings messages for deprecated frequencies (they differ only on " and will be removed in a future version"). I think it makes sense to make them look the same.

Then we can combine some tests in #56346 together, e.g. in pandas/tests/indexes/period/test_period_range.py we can join together test_uppercase_us_ns_deprecated_from_time_series and test_mixcase_us_ns_deprecated_from_time_series.

MarcoGorelli
MarcoGorelli approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, thanks!

@MarcoGorelli MarcoGorelli added this to the 2.2 milestone Dec 12, 2023
@MarcoGorelli MarcoGorelli merged commit f571cce into pandas-dev:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Frequency DateOffsets
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@natmokval @MarcoGorelli