CoW: Avoid warnings in stata code #56392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/io/stata.py
Outdated
| @@ -467,9 +464,9 @@ def g(x: datetime) -> int: | |||
| if bad_loc.any(): | |||
| dates = Series(dates) | |||
There was a problem hiding this comment.
Suggested change
| dates = Series(dates) |
And then below could use the existing dates[bad_loc] ? (if we are otherwise just setting on the _values, there is not much point in converting to a Series?)
There was a problem hiding this comment.
Ah, but from seeing the surrounding code, I assume dates is already a Series, so this wouldn't change anything (but can also be left out then, I assume)
There was a problem hiding this comment.
Yes, we can probably remove it but we already have references, so it won't help with the warning
14 tasks
|
merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #56019