Skip to content

CoW: Avoid warning if temporary object is a copy #56211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2023
Merged

CoW: Avoid warning if temporary object is a copy #56211

merged 3 commits into from
Dec 4, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 27, 2023 •
edited by jorisvandenbossche
Loading

xref #56019

That's the stricter check we talked about today. The cases we exclude here are no-ops without CoW as well, so no need to warn

@jorisvandenbossche jorisvandenbossche added this to the 2.2 milestone Dec 4, 2023
@jorisvandenbossche jorisvandenbossche merged commit 0d22488 into pandas-dev:main Dec 4, 2023
@phofl phofl deleted the chained_view_only branch December 4, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Copy / view semantics
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @jorisvandenbossche