WEB: Better management of releases #56207
Conversation
sorting on version number + sorting out obsolete versions
|
Hi @datapythonista !
Could not figure out how new tests should be called. |
web/pandas_web.py
Outdated
| for _, release_group in grouped_releases | ||
| ] | ||
| # sorting releases by version number | ||
| context["releases"].sort(key=lambda r: r["name"], reverse=True) |
There was a problem hiding this comment.
Shouldn't we sort by the parsed version? Maybe I'm missing something, but feels like sorting by name will make 2.0 be shown before 10.0, no?
There was a problem hiding this comment.
I'm parsing version before that on line 244. Is that ok?
There was a problem hiding this comment.
Ah, true. Makes sense, but probably worth renaming the field from name to something like parsed_version then, no? I think the code is a bit misleading otherwise, at least it was for me.
| "published_at": "2023-01-19T03:34:05Z", | ||
| "tag_name": "v1.5.3xd", | ||
| "assets": None, | ||
| }, |
There was a problem hiding this comment.
Maybe we can add 10.0 to make sure the possible bug commented above is not there.
Good point. I think the normal tests just call pytest for the pandas/ directory. In the CI job to build the website and docs we could add a step to call pytest for the tests in web/. I think that's what makes sense, but other ideas are welcome. |
Can you please point me out a file with CI job for docs and website? Sorry, I'm new to the project. |
https://github.com/pandas-dev/pandas/blob/main/.github/workflows/docbuild-and-upload.yml |
Thanks a lot! Added "Test website" step to ci job. |
|
Amazing job, thanks for taking care of this @Dukastlik, and sorry that reviews took a while. |
Added releases sorting by version number and sorting out obsolete releases in web/pandas_web.py