Adjust tests in extension folder for new string option #56191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 27, 2023
| return self.frame_scalar_exc | ||
| result = self.frame_scalar_exc | ||
|
|
||
| if using_pyarrow_string_dtype() and result is not None: |
There was a problem hiding this comment.
cc @jbrockmendel if this follows how you imagined _get_expected_exception to function
There was a problem hiding this comment.
I am open to other suggestions if we keep in mind that this is a temporary solution until we enable the option by default which will make testing this a lot easier
There was a problem hiding this comment.
this is pretty ugly but since its temporary (and im way late in reviewing) im not inclined to worry about it. There are a bunch of similar things that i think could be improved by catching pa.lib.ArrowNotImplementedError and re-raising as TypeError for cases that are not supposed to work
mroeschke
reviewed
Nov 27, 2023
mroeschke
added
Testing
|
cc @mroeschke gentle ping |
mroeschke
approved these changes
Dec 8, 2023
|
Thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.