Skip to content

BUG: scatter discarding string columns #56142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 23, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@@ -688,7 +688,7 @@ def _compute_plot_data(self):

# GH 18755, include object and category type for scatter plot
if self._kind == "scatter":
include_type.extend(["object", "category"])
include_type.extend(["object", "category", "string"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a test

@mroeschke mroeschke added Visualization plotting Strings String extension data type and string data labels Nov 26, 2023
@mroeschke mroeschke added this to the 2.2 milestone Nov 26, 2023
@mroeschke mroeschke merged commit 45b937d into pandas-dev:main Nov 26, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the plotting_tests branch November 26, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Strings String extension data type and string data Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants