-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPR: Deprecate ravel #56053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DEPR: Deprecate ravel #56053
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b2f2774
DEP: Deprecate ravel
phofl 41f31aa
Merge branch 'main' into dep_ravel
phofl dd9cfe6
Fix ravel deprecations
phofl 054ca87
Update pivot.py
phofl 5a15389
Fix doctest
phofl 28fb76c
Fix view
phofl 636e3c4
Fix
phofl d48e5ca
Update
phofl 146e1aa
Update whatsnew
phofl 5be6f6c
Merge branch 'main' into dep_ravel
phofl 571bc1a
FIx
phofl d54a80c
Add note
phofl cf79da9
Merge branch 'main' into dep_ravel
phofl 4afe81c
Update pandas/core/series.py
jorisvandenbossche bd292ad
Merge branch 'main' into dep_ravel
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -846,6 +846,8 @@ def ravel(self, order: str = "C") -> ArrayLike: | |||||
""" | ||||||
Return the flattened underlying data as an ndarray or ExtensionArray. | ||||||
|
||||||
.. deprecated:: 2.2.0 | ||||||
|
||||||
Returns | ||||||
------- | ||||||
numpy.ndarray or ExtensionArray | ||||||
|
@@ -858,9 +860,15 @@ def ravel(self, order: str = "C") -> ArrayLike: | |||||
Examples | ||||||
-------- | ||||||
>>> s = pd.Series([1, 2, 3]) | ||||||
>>> s.ravel() | ||||||
>>> s.ravel() # doctest: +SKIP | ||||||
array([1, 2, 3]) | ||||||
""" | ||||||
warnings.warn( | ||||||
"Series.ravel is deprecated. The underlying array is already 1D, so " | ||||||
"ravel is not necessary.", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added |
||||||
FutureWarning, | ||||||
stacklevel=2, | ||||||
) | ||||||
arr = self._values.ravel(order=order) | ||||||
if isinstance(arr, np.ndarray) and using_copy_on_write(): | ||||||
arr.flags.writeable = False | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the content of the warning message here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added