Fix apply na overflow #56000
Merged
Fix apply na overflow #56000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 17, 2023
pandas/core/methods/selectn.py
Outdated
Comment on lines
142
to
145
| if n == 0: # avoid OOB access with kth_smallest_c | ||
| kth_val = 0 | ||
| else: | ||
| kth_val = libalgos.kth_smallest(arr.copy(order="C"), n - 1) |
There was a problem hiding this comment.
Suggested change
| if n == 0: # avoid OOB access with kth_smallest_c | |
| kth_val = 0 | |
| else: | |
| kth_val = libalgos.kth_smallest(arr.copy(order="C"), n - 1) | |
| # avoid OOB access with kth_smallest_c | |
| kth_val = libalgos.kth_smallest(arr.copy(order="C"), max(n - 1, 0)) |
I would be more comfortable with this change. Since kth_val is a value in the array and comparisons are made with this value, this may be incorrect if values in arr were all negative for example
mroeschke
approved these changes
Nov 17, 2023
|
Thanks @WillAyd |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another thing flagged by ASAN. I am not very familiar with this algorithm so there may be a better way of doing this, but when
n=0the cython code ends up reading memory one byte to the left of the array