Skip to content

BUG: Set check_exact to true if dtype is int #55934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 27, 2023
Merged

BUG: Set check_exact to true if dtype is int #55934

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4eabcd6
BUG: Set check_exact to true if dtype is int
parthi-siva Nov 13, 2023
bce3087
BUG: Add check to ignore dytype difference
parthi-siva Nov 13, 2023
8fd5e61
TST: Added test cases
parthi-siva Nov 13, 2023
c3ecb84
TST: Fix failing test cases
parthi-siva Nov 13, 2023
6d74ec3
DOC: Update function documentation
parthi-siva Nov 19, 2023
8f608a0
Merge remote-tracking branch 'upstream/main' into BUG-GH#55882
MarcoGorelli Nov 23, 2023
c46b2d6
check_exact only takes effect for floating dtypes
MarcoGorelli Nov 23, 2023
a4eabea
xfail failing test
MarcoGorelli Nov 23, 2023
00b7c91
Update pandas/tests/extension/base/methods.py
MarcoGorelli Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pandas/_testing/asserters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,6 +921,14 @@ def assert_series_equal(
else:
assert_attr_equal("dtype", left, right, obj=f"Attributes of {obj}")

if (
is_integer_dtype(left.dtype)
and is_integer_dtype(right.dtype)
and isinstance(left._values, type(right._values))
and isinstance(right._values, type(left._values))
):
check_exact = True

if check_exact and is_numeric_dtype(left.dtype) and is_numeric_dtype(right.dtype):
left_values = left._values
right_values = right._values
Expand Down
8 changes: 8 additions & 0 deletions pandas/tests/util/test_assert_series_equal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,3 +423,11 @@ def test_check_dtype_false_different_reso(dtype):

with pytest.raises(AssertionError, match="Series are different"):
tm.assert_series_equal(ser_s, ser_ms, check_dtype=False)


def test_check_exact_true_for_int_dtype():
# GH 55882
left = Series([1577840521123000])
right = Series([1577840521123543])
with pytest.raises(AssertionError, match="Series are different"):
tm.assert_series_equal(left, right)