BUG: Keep original values when taking with a new fill value #55929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 13, 2023
| @@ -170,6 +170,13 @@ def test_take_all_empty(self): | |||
| result = a.take([0, 1], allow_fill=True, fill_value=np.nan) | |||
| tm.assert_sp_array_equal(a, result) | |||
|
|
|||
| def test_take_different_fill_value(self): | |||
| # Take with a different fill value shouldn't overwrite the original | |||
| a = pd.array([0.0], dtype=SparseDtype("float64", fill_value=0.0)) | |||
There was a problem hiding this comment.
Could you avoid the 1 letter variable name e.g. use arr
mroeschke
reviewed
Nov 14, 2023
doc/source/whatsnew/v2.2.0.rst
Outdated
| @@ -349,6 +349,7 @@ Datetimelike | |||
| - Bug in addition or subtraction of very large :class:`Tick` objects with :class:`Timestamp` or :class:`Timedelta` objects raising ``OverflowError`` instead of ``OutOfBoundsTimedelta`` (:issue:`55503`) | |||
| - Bug in creating a :class:`Index`, :class:`Series`, or :class:`DataFrame` with a non-nanosecond :class:`DatetimeTZDtype` and inputs that would be out of bounds with nanosecond resolution incorrectly raising ``OutOfBoundsDatetime`` (:issue:`54620`) | |||
| - Bug in creating a :class:`Index`, :class:`Series`, or :class:`DataFrame` with a non-nanosecond ``datetime64`` dtype and inputs that would be out of bounds for a ``datetime64[ns]`` incorrectly raising ``OutOfBoundsDatetime`` (:issue:`55756`) | |||
| - Bug in taking from a :class:`SparseArray` when using a different fill value than the array's fill value. (:issue:`55181`) | |||
There was a problem hiding this comment.
Suggested change
| - Bug in taking from a :class:`SparseArray` when using a different fill value than the array's fill value. (:issue:`55181`) | |
| - Bug in :meth:`SparseArray.take` when using a different fill value than the array's fill value. (:issue:`55181`) |
mroeschke
approved these changes
Nov 20, 2023
|
Thanks @rob-sil |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Nov 21, 2023
…ev#55929) * Keep original values when taking with a new fill value * Switch one-letter name * Fix whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.2.0.rstfile if fixing a bug or adding a new feature.SparseArray'stakemethod could mix up the two possible fill values: the array's fill value and thefill_valueargument provided totake. In the case of a non-empty sparse array whose values were all its fill value,takewould ignore the array's fill value and only use itsfill_valueargument, even for valid indices. The return value would be allfill_value, rather than a mix of the two fill values.