Skip to content

ASV: clean/simplify setup methods #55923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

lukemanley
Copy link
Member

Trying to make some of the setup methods a bit more efficient. Might(?) save around a minute total on the ASV job.

e.g.

import time
from itertools import product
from asv_bench.benchmarks.series_methods import NanOps

param_sets = list(product(*NanOps.params))

t = time.time()
for params in param_sets:
    try:
        NanOps().setup(*params)
    except NotImplementedError:
        pass
print(time.time() - t)

# 11.87  -> main
# 1.90   -> PR

@lukemanley lukemanley added the Benchmark Performance (ASV) benchmarks label Nov 12, 2023
@lukemanley lukemanley added this to the 2.2 milestone Nov 12, 2023
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot of these are reasonable - thanks for the cleanup

@mroeschke mroeschke merged commit c4f0e6f into pandas-dev:main Nov 14, 2023
@mroeschke
Copy link
Member

Thanks @lukemanley

@lukemanley lukemanley deleted the asv-clean-setup-methods branch November 16, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants