Skip to content

REF: make BarPlot attributes cache_readonlys #55878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2023
Merged

REF: make BarPlot attributes cache_readonlys #55878

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
489a906
REF: make BarPlot less stateful
jbrockmendel Nov 8, 2023
97117fa
less state
jbrockmendel Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 40 additions & 18 deletions pandas/plotting/_matplotlib/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1663,42 +1663,63 @@ def _kind(self) -> Literal["bar", "barh"]:
def orientation(self) -> PlottingOrientation:
return "vertical"

def __init__(self, data, **kwargs) -> None:
def __init__(
self,
data,
*,
align="center",
bottom=0,
left=0,
width=0.5,
position=0.5,
log=False,
**kwargs,
) -> None:
# we have to treat a series differently than a
# 1-column DataFrame w.r.t. color handling
self._is_series = isinstance(data, ABCSeries)
self.bar_width = kwargs.pop("width", 0.5)
pos = kwargs.pop("position", 0.5)
kwargs.setdefault("align", "center")
self.bar_width = width
self._align = align
self._position = position
self.tick_pos = np.arange(len(data))

bottom = kwargs.pop("bottom", 0)
left = kwargs.pop("left", 0)
if is_list_like(bottom):
bottom = np.array(bottom)
if is_list_like(left):
left = np.array(left)
self.bottom = bottom
self.left = left

self.log = kwargs.pop("log", False)
self.log = log

MPLPlot.__init__(self, data, **kwargs)

@cache_readonly
def ax_pos(self) -> np.ndarray:
return self.tick_pos - self.tickoffset

@cache_readonly
def tickoffset(self):
if self.stacked or self.subplots:
self.tickoffset = self.bar_width * pos
if kwargs["align"] == "edge":
self.lim_offset = self.bar_width / 2
else:
self.lim_offset = 0
elif kwargs["align"] == "edge":
return self.bar_width * self._position
elif self._align == "edge":
w = self.bar_width / self.nseries
self.tickoffset = self.bar_width * (pos - 0.5) + w * 0.5
self.lim_offset = w * 0.5
return self.bar_width * (self._position - 0.5) + w * 0.5
else:
self.tickoffset = self.bar_width * pos
self.lim_offset = 0
return self.bar_width * self._position

self.ax_pos = self.tick_pos - self.tickoffset
@cache_readonly
def lim_offset(self):
if self.stacked or self.subplots:
if self._align == "edge":
return self.bar_width / 2
else:
return 0
elif self._align == "edge":
w = self.bar_width / self.nseries
return w * 0.5
else:
return 0

# error: Signature of "_plot" incompatible with supertype "MPLPlot"
@classmethod
Expand Down Expand Up @@ -1749,6 +1770,7 @@ def _make_plot(self, fig: Figure) -> None:
start = 1
start = start + self._start_base

kwds["align"] = self._align
if self.subplots:
w = self.bar_width / 2
rect = self._plot(
Expand Down